Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adding multi tenant support #19

Merged

Conversation

JoseWhite
Copy link
Contributor

This PR adds functionality to overwrite HubSpot access-token at call time.
The idea is use the gem in a multi-tenant environment where not everyone uses the same hubspot account.

@JoseWhite JoseWhite marked this pull request as ready for review September 5, 2024 20:50
@LannyBose LannyBose self-requested a review September 5, 2024 20:50
Copy link
Collaborator

@LannyBose LannyBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LannyBose
Copy link
Collaborator

@oroth8 We had to remove the test coverage checks for forked PRs because Action Secrets aren't provided to forked branches on CI runs. See more here:

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target

@LannyBose LannyBose merged commit f3429f2 into oroth8:main Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants