[chore] reduce verbosity on build
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrauhu
suggested changes
Apr 3, 2024
There was a problem hiding this comment.
Hello, @orph3usLyre.
Added small note about Windows environment variables.
muddy_macros/src/internal.rs
Outdated
| #[cfg(windows)] | ||
| // language=cmd | ||
| eprintln!(r#"set "{env_name}={key}""#); | ||
| eprintln!(r#"set {env_name}="{key}""#); |
There was a problem hiding this comment.
It's a wrong example of usage for Windows:
set {env_name}="{key}"Because an environment variable value will be contain quotes (") on each side, like:
"value"
Correct example:
set "{env_name}={key}"It's works for values with and without spaces.
There was a problem hiding this comment.
Thanks for the catch! Fixing this now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for contributor @mrauhu:
I know that we spoke about this issue already a couple of times, so I reached out to a few other devs to ask their opinion about how much/if any output text should be produced by the library. There was a pretty strong preference for not having any output at all. I thought about this for a little bit, and I decided to go with this route. Generally, this type of library should only be used by someone who has read the documentation, and all the instructions should probably be there rather than as actual project output at every build. However, I am planning on making a
cargo-muddyCLI tool that will automatically obfuscate a rust project (without the need to import the library). And I think that's where all the output would be important (since it will only run once, rather than every build). Thanks again for the help!