Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing closing response body #498

Closed
wants to merge 1 commit into from

Conversation

alexandear
Copy link
Contributor

Fix possible resource leaks by adding a statement that closes a response body.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

From the documentation:

The caller must close the response body when finished with it

Also, see this article for a deep dive into the problem.

@alnr
Copy link
Contributor

alnr commented Jun 13, 2024

This change is on branch v3.

@alnr alnr closed this Jun 13, 2024
@alexandear alexandear deleted the fix-close-resp-body branch June 13, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants