Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document rate-limits #1601

Merged
merged 9 commits into from
Dec 8, 2023
Merged

chore: document rate-limits #1601

merged 9 commits into from
Dec 8, 2023

Conversation

tricky42
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@tkjwa
Copy link

tkjwa commented Nov 15, 2023

Do the rate limit on whoami also apply when using Edge sessions ?

@tricky42
Copy link
Contributor Author

@tricky42 tricky42 marked this pull request as ready for review November 15, 2023 12:57
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
should we also link it here https://www.ory.sh/docs/ecosystem/security and on h1 for our hackers?

also should we add a disclaimer that these rates are subject to change, the documentation might not always reflect the latest state and is more to give you a ballpark idea?

docs/guides/rate-limits.mdx Outdated Show resolved Hide resolved
Co-authored-by: Vincent <[email protected]>
@tricky42
Copy link
Contributor Author

tricky42 commented Nov 15, 2023

Do the rate limit on whoami also apply when using Edge sessions?

Yes, the rate limit on whoami applies when using edge sessions, as we trigger a revalidation with each request. In the future, we will further improve the logic here. The limits for whoami, therefore, are significantly higher than the other limits.

@tricky42 tricky42 requested a review from aeneasr December 8, 2023 20:13
@tricky42 tricky42 merged commit 510c013 into master Dec 8, 2023
8 checks passed
@tricky42 tricky42 deleted the abu/rate-limits branch December 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants