Skip to content
This repository was archived by the owner on Dec 31, 2022. It is now read-only.

ci: enforce conventional commits #55

Merged
merged 11 commits into from
Jun 20, 2022
Merged

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Jun 17, 2022

I've struggled with conventional commits on enough PRs to automate this. The app we currently seem to use (https://github.com/zeke/semantic-pull-requests) is no longer maintained. This sets up the recommended GitHub Action instead.

  • checks the commit message
  • allows the custom types used by Ory
  • works with external forks
  • enforces lowercase

I'm doing a few test commits to verify that this works, then will tag people.
Edit: this is done now.

@kevgo kevgo changed the title Enforce conventional commits ci: Enforce conventional commits Jun 17, 2022
@kevgo kevgo changed the title ci: Enforce conventional commits ci: enforce conventional commits Jun 17, 2022
@kevgo kevgo requested a review from aeneasr June 17, 2022 16:20
@kevgo
Copy link
Contributor Author

kevgo commented Jun 17, 2022

@aeneasr what do you think? I'm happy to add this to all the other repos as well.

@aeneasr
Copy link
Member

aeneasr commented Jun 17, 2022

Nice! We can sync this across al repos by using github.com/ory/meta which has a sync action: https://github.com/ory/meta/blob/master/.github/workflows/sync.yml

@kevgo
Copy link
Contributor Author

kevgo commented Jun 17, 2022

Cool that you have a solution to sync such things across so many repos!

How do we delete the now obsolete .github/semantic.yml from all repos? After a cursory glance, I see the sync script only copying files from the meta repo to the target repos (except for the ISSUE_TEMPLATE directory, which it clears out first).

@aeneasr
Copy link
Member

aeneasr commented Jun 20, 2022

How do we delete the now obsolete .github/semantic.yml from all repos? After a cursory glance, I see the sync script only copying files from the meta repo to the target repos (except for the ISSUE_TEMPLATE directory, which it clears out first).

Good question, it might make sense to use rclone / rcopy instead of a dumb cp?

@kevgo
Copy link
Contributor Author

kevgo commented Jun 20, 2022

I don't have a good answer right now. Isn't rcopy/rclone similar to deleting the target dir and copying everything over again (just faster)? If we do anything destructive (deleting files), I'm exponentially more concerned about committing straight to master while bypassing all CI and reviews.

I have created ory/meta#150 to keep thinking about this specific issue. Merging this PR for conventional commit enforcement in this repo in for now.

@kevgo kevgo merged commit 98e8f47 into master Jun 20, 2022
@kevgo kevgo deleted the kg-enforce-conventional-commits branch June 20, 2022 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants