Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update openapi-generator to 7.8.0 for dotnet #382

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

sbward
Copy link
Contributor

@sbward sbward commented Nov 3, 2024

Update open-apigenerator to 7.8.0 for dotnet to fix ApiClient issue in Blazor WASM environments

Related Issue or Design Document

Updates open-apigenerator to 7.8.0 to include a fix for Blazor WebAssembly where API calls trigger a System.PlatformNotSupportedException due to invoking a blocking wait from a WASM environment. I believe this bug could be triggered by making any call from any Ory Client class in a Blazor WebAssembly environment. As such Ory Client is unusable in Blazor WASM without this fix.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@sbward sbward changed the title Update openapi-generator to 7.8.0 for dotnet chore: update openapi-generator to 7.8.0 for dotnet Nov 3, 2024
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense! Thank you.

AFAIK, the currently generated dotnet SDK is broken in some places, and this should contain a few important fixes!

@jonas-jonas jonas-jonas merged commit 7d4056f into ory:master Nov 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants