fix(healthx): separate version and health routes

ory · Mar 19, 2021 · d80f3e1 · d80f3e1
1 parent 30d25bb
commit d80f3e1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/healthx/handler.go b/healthx/handler.go
@@ -77,10 +77,14 @@ func NewHandler(
 	}
 }
 
-// SetRoutes registers this handler's routes.
-func (h *Handler) SetRoutes(r *httprouter.Router, shareErrors bool) {
+// SetHealthRoutes registers this handler's routes for health checking.
+func (h *Handler) SetHealthRoutes(r *httprouter.Router, shareErrors bool) {
 	r.GET(AliveCheckPath, h.Alive)
 	r.GET(ReadyCheckPath, h.Ready(shareErrors))
+}
+
+// SetHealthRoutes registers this handler's routes for health checking.
+func (h *Handler) SetVersionRoutes(r *httprouter.Router) {
 	r.GET(VersionPath, h.Version)
 }
 

diff --git a/healthx/handler_test.go b/healthx/handler_test.go
@@ -47,7 +47,8 @@ func TestHealth(t *testing.T) {
 		},
 	}
 	router := httprouter.New()
-	handler.SetRoutes(router, true)
+	handler.SetHealthRoutes(router, true)
+	handler.SetVersionRoutes(router)
 	ts := httptest.NewServer(router)
 	c := http.DefaultClient