Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pc registration fix #18766

Merged
merged 4 commits into from
Mar 4, 2024
Merged

pc registration fix #18766

merged 4 commits into from
Mar 4, 2024

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Feb 28, 2024 •
edited
Loading

@pdostal pdostal requested a review from asmorodskyi February 28, 2024 16:16
asmorodskyi
asmorodskyi approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdostal pdostal force-pushed the pc_registration_fix branch from 2570383 to 996182a Compare February 28, 2024 16:37
@pdostal pdostal added the WIP Work in progress label Feb 28, 2024
grisu48
grisu48 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, otherwise LGTM

data/publiccloud/ssh_config Outdated Show resolved Hide resolved
@alvarocarvajald
Copy link
Contributor

alvarocarvajald commented Feb 29, 2024 •
edited
Loading

Adding a saptune VR: https://openqa.suse.de/tests/13645287

But don't expect a passing test, as these SAP tests for 15-SP6 are currently failing on registration.

mpagot
mpagot approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-kpappas
Copy link
Contributor

a-kpappas commented Feb 29, 2024 •
edited
Loading

Adding a saptune VR: https://openqa.suse.de/tests/13645287

But don't expect a passing test, as these SAP tests for 15-SP6 are currently failing on registration.

ERROR OUTPUT: Error: importing EC2 Key Pair (qesaposd13645287 - terraform): InvalidKey.Format: Key is not in valid OpenSSH public key format

@pdostal pdostal force-pushed the pc_registration_fix branch 2 times, most recently from f14d333 to a5c2c4e Compare February 29, 2024 15:14
@pdostal pdostal added Ready Ready for review Verification-Runs-needed and removed WIP Work in progress labels Feb 29, 2024
@pdostal pdostal force-pushed the pc_registration_fix branch 2 times, most recently from b714410 to 7048a50 Compare February 29, 2024 16:03
@pdostal pdostal self-assigned this Feb 29, 2024
@pdostal pdostal force-pushed the pc_registration_fix branch from 7048a50 to a5a8183 Compare February 29, 2024 16:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

asmorodskyi
asmorodskyi approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Looks like really big work was done here ! Obviously LGTM !

ricardobranco777
ricardobranco777 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, otherwise LGTM

lib/publiccloud/utils.pm Outdated Show resolved Hide resolved
@pdostal pdostal force-pushed the pc_registration_fix branch 2 times, most recently from a412a59 to 7ad49a8 Compare March 4, 2024 09:09
@pdostal pdostal force-pushed the pc_registration_fix branch from 7ad49a8 to 4daff4a Compare March 4, 2024 10:13
@asmorodskyi asmorodskyi merged commit 1407b61 into os-autoinst:master Mar 4, 2024
10 of 11 checks passed
@mloviska mloviska mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpagot mpagot mpagot approved these changes

@grisu48 grisu48 grisu48 approved these changes

@ricardobranco777 ricardobranco777 ricardobranco777 approved these changes

@asmorodskyi asmorodskyi asmorodskyi approved these changes

@m-dati m-dati Awaiting requested review from m-dati m-dati is a code owner

Assignees

@pdostal pdostal

Labels
Ready Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pdostal @alvarocarvajald @a-kpappas @grisu48 @ricardobranco777 @asmorodskyi @mpagot