Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share conversion code between LibGAP.jl and JuliaInterface #146

Closed
fingolfin opened this issue Nov 7, 2018 · 0 comments
Closed

Share conversion code between LibGAP.jl and JuliaInterface #146

fingolfin opened this issue Nov 7, 2018 · 0 comments
Assignees
Labels
topic: conversion Issue related to conversion

Comments

@fingolfin
Copy link
Member

Right now, many conversions are implemented twice: once in the GAP C kernel extension, see e.g. _ConvertedFromJulia_internal and _ConvertedToJulia_internal; and once in Julia, see from_gap and to_gap in LibGAP.jl/src/conversion.jl.

There are multiple problems with that:

  • we have to duplicate a lot of work
  • which conversions resp. types are supported can and will differ
  • error checking differs
  • one side may support other types than the other

Therefore, we should think about ways that allow us to implement all these conversions once for both sides. Whether this is done in C, GAP or Julia, or a mix of them does not matter that much to me, as long as it is efficient and available from both sides, and flexible enough for our purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: conversion Issue related to conversion
Projects
None yet
Development

No branches or pull requests

2 participants