Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JuliaInterface conversion methods in LibGAP.jl #147

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

sebasguts
Copy link
Contributor

See #146

@sebasguts sebasguts requested a review from fingolfin November 8, 2018 15:43
@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #147 into master will increase coverage by 2.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   55.29%   57.43%   +2.14%     
==========================================
  Files          42       44       +2     
  Lines        2465     2608     +143     
==========================================
+ Hits         1363     1498     +135     
- Misses       1102     1110       +8
Impacted Files Coverage Δ
LibGAP.jl/src/ccalls.jl 100% <100%> (ø) ⬆️
LibGAP.jl/src/conversion.jl 100% <100%> (ø) ⬆️
JuliaExperimental/PackageInfo.g 95.77% <0%> (ø)
JuliaInterface/PackageInfo.g 92.06% <0%> (ø)

@sebasguts sebasguts force-pushed the symmetric_conversion branch from ea7a06a to 32b4650 Compare November 8, 2018 15:52
LibGAP.jl/src/ccalls.jl Show resolved Hide resolved
LibGAP.jl/src/conversion.jl Show resolved Hide resolved
@sebasguts sebasguts force-pushed the symmetric_conversion branch from 32b4650 to f073191 Compare November 13, 2018 12:58
@fingolfin fingolfin merged commit 2236eea into oscar-system:master Nov 13, 2018
@sebasguts sebasguts deleted the symmetric_conversion branch November 14, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants