Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper bound to GAPTypes dependency #299

Closed
fingolfin opened this issue Nov 15, 2019 · 2 comments · Fixed by #300
Closed

Add upper bound to GAPTypes dependency #299

fingolfin opened this issue Nov 15, 2019 · 2 comments · Fixed by #300

Comments

@fingolfin
Copy link
Member

On JuliaRegistries/General#5422 we were told:

The following dependencies do not have a compat entry that has an upper bound: GAPTypes

@ThomasBreuer
Copy link
Member

Currently GAPTypes.jl has version "1.0.0".
We could be very conservative in the sense that any change in GAPTypes.jl will likely be incompatible, and will require a new release of GAP.jl.
If I understand the documentation in Pkg.jl right then we can express this as follows.

[compat]
GAPTypes = "= 1.0.0"

@fredrikekre
Copy link

Bump for JuliaRegistries/General#5422. I would recommend:

[compat]
GAPTypes = "1"

if you are following semantic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants