Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upper bound to GAPTypes dependency #300

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Add upper bound to GAPTypes dependency #300

merged 1 commit into from
Nov 27, 2019

Conversation

fingolfin
Copy link
Member

Resolves #299

@codecov
Copy link

codecov bot commented Nov 27, 2019 •
edited
Loading

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   71.59%   71.59%           
=======================================
  Files          59       59           
  Lines        3960     3960           
=======================================
  Hits         2835     2835           
  Misses       1125     1125

ThomasBreuer
ThomasBreuer approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks o.k.

@fingolfin
Copy link
Member Author

There were two failed Travis jobs, both of them flukes. One was with Julia nightly, which I resolved by re-running the job. The remaining one is due to Julia 1.3.0-rc5 (still) being used by some Travis builders, while others already use Julia 1.3.0 (released last night), which fixes that regression. Restarting the job so far didn't help (I got 1.3.0-rc5 each time), I'll keep trying. Possibly also have to wait a day or two to make sure all Travis build servers switched to the new Julia version.

@fingolfin fingolfin merged commit e05b42a into oscar-system:master Nov 27, 2019
@fingolfin fingolfin deleted the mh/bound-GAPTypes branch November 27, 2019 14:36
@fingolfin fingolfin mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add upper bound to GAPTypes dependency
2 participants
@fingolfin @ThomasBreuer