Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure for pull request #300 #301

Closed
ThomasBreuer opened this issue Nov 27, 2019 · 2 comments
Closed

test failure for pull request #300 #301

ThomasBreuer opened this issue Nov 27, 2019 · 2 comments

Comments

@ThomasBreuer
Copy link
Member

The (first) failure at https://github.com/oscar-system/GAP.jl/pull/300/checks?check_run_id=322748382 looks strange.
My interpretation is that first GAP's GAPToJulia creates a nested array of the following structure.

julia> l = Any[ Any[ 1, 2 ], Any[ 3, 4 ] ]
2-element Array{Any,1}:
 Any[1, 2]
 Any[3, 4]

Then Julia's hcat turns the nested array into a 2-dimensional array.

julia> hcat( l... )
2×2 Array{Int64,2}:
 1  3
 2  4

julia> Base.repr( hcat( l... ) )
"[1 3; 2 4]"

In the seven (or six) jobs where the tests pass, the type of the array says that the entries are Int64, as in the above output, whereas the entries are Any in the (first) failed job.
I would understand if the type would be Array{Any,2} since Julia 1.3, but I cannot reproduce this Any situation in Julia 1.3 or Julia 1.4.
And how can it happen that the test result depends on the used GAP?

@fingolfin
Copy link
Member

These failures are flukes, caused by some Travis VMs still using Julia 1.3.0-rc5. Once all are upgraded to 1.3.0 this issue will resolve itself

@fingolfin
Copy link
Member

This went away for #300 now, as predicted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants