Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect coverage for all dirs, including LibGAP.jl #105

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

fingolfin
Copy link
Member

No description provided.

Copy link
Contributor

@sebasguts sebasguts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

If the tests pass, we can merge it.

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #105 into master will decrease coverage by 1.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   51.77%   50.43%   -1.35%     
==========================================
  Files          37       42       +5     
  Lines        2476     2554      +78     
==========================================
+ Hits         1282     1288       +6     
- Misses       1194     1266      +72
Impacted Files Coverage Δ
LibGAP.jl/src/initialization.jl 0% <0%> (ø)
LibGAP.jl/src/ccalls.jl 16.66% <0%> (ø)
LibGAP.jl/src/conversion.jl 0% <0%> (ø)
LibGAP.jl/src/gap.jl 21.42% <0%> (ø)
LibGAP.jl/src/libgap.jl 100% <0%> (ø)

@sebasguts sebasguts merged commit ee5d685 into oscar-system:master Oct 30, 2018
@fingolfin fingolfin deleted the mh/LibGAP.jl-coverage branch October 30, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants