Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JuliaTypeInfo by Julia.typeof #1084

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin changed the title Replace JuliaTypeInfo by Julia.typeinf Replace JuliaTypeInfo by Julia.typeof Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.39%. Comparing base (9038df6) to head (ee20cea).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/JuliaExperimental/gap/numfield.g 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   74.47%   75.39%   +0.92%     
==========================================
  Files          55       55              
  Lines        4587     4573      -14     
==========================================
+ Hits         3416     3448      +32     
+ Misses       1171     1125      -46     
Files with missing lines Coverage Δ
pkg/JuliaInterface/gap/JuliaInterface.gd 100.00% <ø> (ø)
pkg/JuliaInterface/gap/JuliaInterface.gi 91.46% <ø> (-0.50%) ⬇️
pkg/JuliaExperimental/gap/numfield.g 95.24% <50.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better use the object itself than a string value.

@ThomasBreuer ThomasBreuer merged commit caf0426 into master Dec 13, 2024
21 checks passed
@ThomasBreuer ThomasBreuer deleted the mh/JuliaTypeInfo branch December 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants