Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP: add and use ReplaceBinding helper #1085

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

fingolfin
Copy link
Member

This is a variant of Oscar's ReplaceGapFunc but I figure it is
be useful for other code.

This is a variant of Oscar's `ReplaceGapFunc` but I figure it is
be useful for other code.
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47%. Comparing base (1992296) to head (c09bcf2).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
+ Coverage   75.43%   75.47%   +0.03%     
==========================================
  Files          55       55              
  Lines        4580     4587       +7     
==========================================
+ Hits         3455     3462       +7     
  Misses       1125     1125              
Files with missing lines Coverage Δ
gap/exec.g 100.00% <100.00%> (ø)
gap/systemfile.g 100.00% <100.00%> (ø)

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea about these low-lever GAP functions, but seems to work

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, why not.

If the variable in question has no value (yet) then VAL_GVAR will run into an error, which is fine.

@ThomasBreuer ThomasBreuer merged commit 2faeb7b into master Dec 17, 2024
21 checks passed
@ThomasBreuer ThomasBreuer deleted the mh/ReplaceBinding branch December 17, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants