Remove a bunch of files from mutable GAP root #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GAP dropped its compat mode, so we can follow suite, and not worry about providing a `bin/$GAPARCH/gac` symlink - no distributed GAP package still uses `#include "src/compiled.h"` so get rid of the symlink from `GAPDIR/include/gap` to `src` - there is no need to symlink the `lib` directory containing the `libgap` shared library (I am not sure why we did this at all?) - finally, the symlink from `GAPDIR/bin/gap` to `gap` can be removed as (a) that executable can't be executed directly anyway, and (b) all GAP packages in the distro these days find the GAP executable by looking its path up on `sysinfo.gap`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1103 +/- ##
==========================================
- Coverage 74.94% 74.90% -0.04%
==========================================
Files 55 55
Lines 4609 4603 -6
==========================================
- Hits 3454 3448 -6
Misses 1155 1155
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worry about providing a
bin/$GAPARCH/gacsymlink#include "src/compiled.h"so get rid of the symlink from
GAPDIR/include/gaptosrclibdirectory containing thelibgapshared library (I am not sure why we did this at all?)GAPDIR/bin/gaptogapcan be removedas (a) that executable can't be executed directly anyway, and (b)
all GAP packages in the distro these days find the GAP executable
by looking its path up on
sysinfo.gap