Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong integer type check #112

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Fixed wrong integer type check #112

merged 1 commit into from
Oct 31, 2018

Conversation

sebasguts
Copy link
Contributor

No description provided.

@sebasguts sebasguts requested a review from fingolfin October 31, 2018 15:14
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   51.68%   51.68%           
=======================================
  Files          42       42           
  Lines        2552     2552           
=======================================
  Hits         1319     1319           
  Misses       1233     1233

fingolfin
fingolfin approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of a test (like with the problem that prompted you to make the change) would be great...

@fingolfin fingolfin merged commit f918e27 into oscar-system:master Oct 31, 2018
@sebasguts sebasguts mentioned this pull request Nov 7, 2018
Merged
@sebasguts sebasguts deleted the integer_fix branch November 14, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebasguts @fingolfin