Add some LibGAP.jl tests and run them on Travis #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 51.68% 51.99% +0.31%
==========================================
Files 42 42
Lines 2552 2552
==========================================
+ Hits 1319 1327 +8
+ Misses 1233 1225 -8
|
fingolfin
force-pushed
the
mh/LibGAP.jl-tests
branch
from
76f2c3d to
7f95f19
Compare
fingolfin
force-pushed
the
mh/LibGAP.jl-tests
branch
from
7f95f19 to
b3585a5
Compare
sebasguts
approved these changes
Nov 1, 2018
| @@ -0,0 +1,6 @@ | |||
|
|
|||
| @test LibGAP.CSTR_STRING(GAP.GAPFuncs.String(GAP.GAPFuncs.PROD(2^59,2^59))) == "332306998946228968225951765070086144" | |||
There was a problem hiding this comment.
Bikeshed time: I think we should put such a test in a different file, say basic.jl or convert.jl. runtests_includes.jl should then just include those files.
The double indirection as opposed to the standard Julia testing is because we autogenerate runtests.jl
There was a problem hiding this comment.
I propose something else: let's put the autogenerated data into a seprate file, say gap_path.jl, which then is included by a static, non generated runtests.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #102