Add QUO and LQUO methods for IsJuliaObject, improve tests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 54.28% 54.33% +0.05%
==========================================
Files 44 44
Lines 2590 2593 +3
==========================================
+ Hits 1406 1409 +3
Misses 1184 1184
|
sebasguts
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deliberately ignores the differences between
/and//on the Julia side, just like we did with the/and\Julia convenience method which call QUO and LQUO. This means that dividing Julia integers produces Julia floats. While GAP users may initially find this confusing, I think it is by far the easiest and least problematic approach to the problem. Any attempts to shoehorn GAP semantics onto Julia objects (e.g. by being "clever" and having/in GAP call either Julia's/or//, depending on the input) IMHO is doomed to failure.