Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for integer conversion #136

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin requested a review from sebasguts November 6, 2018 10:01
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #136 into master will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   54.28%   54.63%   +0.34%     
==========================================
  Files          44       44              
  Lines        2590     2590              
==========================================
+ Hits         1406     1415       +9     
+ Misses       1184     1175       -9
Impacted Files Coverage Δ
JuliaInterface/src/JuliaInterface.c 91.26% <0%> (+2.91%) ⬆️

Copy link
Contributor

@sebasguts sebasguts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you :)

@sebasguts sebasguts merged commit 2e21727 into oscar-system:master Nov 6, 2018
@fingolfin fingolfin deleted the mh/int-conversion branch November 6, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants