Remove code "converting" T_PERM{2,4} to Julia arrays #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was untested, and seems of dubious use to me: Instead, if somebody needs to do this, they should be able to simply use `ListPerm`, followed by a conversion from plist to array. If that is not fast enough because, say, someone need to convert a million permutations, then with overwhelming probably they are doing something very wrong. But if a legitimate use case pops up, we can still add back similar code. Although I still would not want to have it in the "generic" `ConvertedToJulia` function; rather it should be in a dedicated `ConvertGAPPermToJuliaArray` function.
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 54.28% 54.54% +0.25%
==========================================
Files 44 44
Lines 2590 2574 -16
==========================================
- Hits 1406 1404 -2
+ Misses 1184 1170 -14
|
sebasguts
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was untested, and seems of dubious use to me: Instead, if somebody
needs to do this, they should be able to simply use
ListPerm, followed by aconversion from plist to array.
If that is not fast enough because, say, someone need to convert a million
permutations, then with overwhelming probably they are doing something very
wrong. But if a legitimate use case pops up, we can still add back similar
code. Although I still would not want to have it in the "generic"
ConvertedToJuliafunction; rather it should be in a dedicatedConvertGAPPermToJuliaArrayfunction.