Replace IsGapObj with our own is_gapobj #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `IsGapObj` stands out from the GAP headers as an ugly hack. I'd rather remove it from GAP, and have us be self-contained.
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=========================================
+ Coverage 55.89% 55.99% +0.1%
=========================================
Files 44 44
Lines 2605 2611 +6
=========================================
+ Hits 1456 1462 +6
Misses 1149 1149
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
IsGapObjstands out from the GAP headers as anugly hack. I'd rather remove it from GAP, and have us be self-contained.