Add test for LibGAP.jl, fix bug in Base.string method #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 56.44% 55.29% -1.16%
==========================================
Files 44 42 -2
Lines 2599 2465 -134
==========================================
- Hits 1467 1363 -104
+ Misses 1132 1102 -30
|
fingolfin
force-pushed
the
mh/cov
branch
2 times, most recently
from
a1f7a48 to
c644f3d
Compare
sebasguts
approved these changes
Nov 12, 2018
| @@ -13,7 +13,7 @@ function Base.show( io::IO, obj::Union{MPtr,GAP.GapFFE} ) | |||
| end | |||
|
|
|||
| function Base.string( obj::Union{MPtr,GAP.GapFFE} ) | |||
| str = GAP.String( obj ) | |||
| str = GAP.Globals.String( obj ) | |||
| return CSTR_STRING( str ) | |||
There was a problem hiding this comment.
Nitpick: Shouldn't we use from_gap here?
There was a problem hiding this comment.
I think it's fine either way, but I'd prefer to merge it as-is, with minimal changes. But feel free to edit this PR, or change it in another PR.
There was a problem hiding this comment.
It can be changed later, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.