Remove GAPRat code #149
Merged
Remove GAPRat code #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is not needed anymore due the existence of the convenience wrappers for arithmetic operations on GAP objects in Julia, resp. on Julia objects in GAP. Moreover, this code was buggy; and was not yet converted to use `ForeignGAP.MPtr` (leading to GC crash). All in all, it seems best to "conclude" this experiment by removing it. Resolves oscar-system#71
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 55.29% 53.82% -1.48%
==========================================
Files 42 39 -3
Lines 2465 2315 -150
==========================================
- Hits 1363 1246 -117
+ Misses 1102 1069 -33
|
|
@ThomasBreuer I think this is your code, isn't it? So I think you should say whether you agree with removing it, or whether you'd prefer to work on updating it. |
ThomasBreuer
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is not needed anymore due the existence of the convenience wrappers
for arithmetic operations on GAP objects in Julia, resp. on Julia objects in
GAP.
Moreover, this code was buggy; and was not yet converted to use
ForeignGAP.MPtr(leading to GC crash). All in all, it seems best to"conclude" this experiment by removing it.
Resolves #71