Removed libgap module #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
requested changes
Nov 13, 2018
JuliaInterface/src/JuliaInterface.c
Outdated
| @@ -51,13 +51,10 @@ jl_module_t * get_module_from_string(char * name) | |||
| // This function needs to be called after the `gaptypes.jl` | |||
| // file is loaded into Julia and the GAP module is present. | |||
| // Therefore we do not call in InitKernel, but in the `read.g` file. | |||
| Obj Func_InitializeGAPFFEType(Obj self) | |||
| Obj Func_InitializeInternalGlobalVariables(Obj self) | |||
There was a problem hiding this comment.
It doesn't matter right now, but the name _InitializeInternalGlobalVariables of course does not indicate where it is from; perhaps we should imitate SingularInterface and NormalizInterface, and start using a common name prefix like _JI, at least for our internal functions?
| if !libgap.gap_is_initialized | ||
| libgap.run_it(GAPPATH) | ||
| if !GAP.gap_is_initialized | ||
| GAP.run_it(GAPPATH) |
There was a problem hiding this comment.
The README also needs to be adapted in the same way, i.e., changing libgap.run_it to GAP.run_it
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 54% 54.04% +0.03%
==========================================
Files 39 39
Lines 2324 2326 +2
==========================================
+ Hits 1255 1257 +2
Misses 1069 1069
|
sebasguts
force-pushed
the
removed_libgap_modules
branch
from
276440b to
6031011
Compare
sebasguts
force-pushed
the
removed_libgap_modules
branch
from
6031011 to
20f30b6
Compare
fingolfin
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.