Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JuliaModule C command #154

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

sebasguts
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #154 into master will increase coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #154      +/-   ##
=========================================
+ Coverage    54.1%   54.3%   +0.19%     
=========================================
  Files          39      39              
  Lines        2329    2337       +8     
=========================================
+ Hits         1260    1269       +9     
+ Misses       1069    1068       -1
Impacted Files Coverage Δ
JuliaInterface/src/JuliaInterface.c 95.92% <ø> (+0.24%) ⬆️
JuliaInterface/gap/JuliaInterface.gi 92.52% <100%> (+0.55%) ⬆️
JuliaInterface/gap/JuliaInterface.gd 100% <100%> (ø) ⬆️
JuliaInterface/read.g 100% <0%> (ø) ⬆️
JuliaInterface/init.g 72.09% <0%> (ø) ⬆️

@sebasguts sebasguts force-pushed the remove_julia_module_c_func branch from 268d47d to 35db843 Compare November 14, 2018 09:39
@fingolfin fingolfin merged commit f266bd0 into oscar-system:master Nov 14, 2018
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one formulation should be fixed, otherwise the changes are fine.

Error( "JuliaModule: <name> must be a string" );
fi;
if not IsBound( Julia.(name) ) then
Error( "JuliaModule: Module <name> does not exists, did you import it?" );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write "does not exist" instead of "does not exists", in two places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants