added first tests using Singular.jl #157
Conversation
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
===========================================
+ Coverage 53.96% 65.38% +11.42%
===========================================
Files 39 39
Lines 2320 2320
===========================================
+ Hits 1252 1517 +265
+ Misses 1068 803 -265
|
| end ); | ||
|
|
||
|
|
||
| InstallOtherMethod( GcdOp, | ||
| IsIdenticalObj, | ||
| [ "IsSingularPolynomial", "IsSingularPolynomial" ], | ||
| function( f, g ) | ||
| return SingularElement( f, Julia.Base.gcd( f, g ) ); | ||
| return SingularElement( f, Julia.Base.gcd( | ||
| JuliaPointer( f ), JuliaPointer( g ) ) ); |
There was a problem hiding this comment.
@sebasguts and me just discussed an extension to the conversion code that would in effect automatically call JuliaPointer to "unwrap" high-level wrapper objects, as long as those high-level objects are in a suitable filter (say, IsAutomaticUnwrappingJuliaWrapper or so...). Then the above change could be reverted to the old version.
There was a problem hiding this comment.
Should this behavior (automatically unwrapping or not) really belong on an object,
or does it depend on the situation whether one wants to unwrap or not?
There was a problem hiding this comment.
We have been discussing this as part of how to deal with extended automatic conversions of arguments for method calls (as opposed to just performing the absolute necessary conversions). We think we have a good plan for that now, and are working on implementing and writing up more about this. In the meantime, this is nothing that should delay this PR.
ThomasBreuer
force-pushed
the
TB_first_test_of_singular
branch
from
72a7cdf to
b69449d
Compare
No description provided.