Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion in conversion #169

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

fingolfin
Copy link
Member

Fixes #165
Fixes #167

@fingolfin fingolfin requested a review from sebasguts November 23, 2018 09:06
@fingolfin
Copy link
Member Author

While PR #168 fixes the issues in #167 by adding the requested conversion, this PR fixes the other aspect, namely that an unsupported conversion lead to a crash -- now it leads to an error. E.g. this GAP code now errors, instead of crashing:

GAPToJulia( JuliaEvalString( "String" ), "a" );

And so does this Julia code:

GAP.gap_to_julia( Dict{Int64,Int64}, GAP.julia_to_gap( "a" ) )  // used to crash
GAP.gap_to_julia( Dict{Int64,Int64}, 1 ) // used to produce StackOverflowError

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   54.72%   54.72%           
=======================================
  Files          37       37           
  Lines        1683     1683           
=======================================
  Hits          921      921           
  Misses        762      762
Impacted Files Coverage Δ
LibGAP.jl/src/gap_to_julia.jl 95.76% <100%> (ø) ⬆️

@sebasguts
Copy link
Contributor

I will merge this once travis is finished

@sebasguts sebasguts merged commit cde820e into oscar-system:master Nov 23, 2018
@fingolfin fingolfin deleted the mh/inf-recursion branch November 23, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants