adjusted JuliaExperimental to the new conversion rules #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adjusted the function calls to the new rules (from pull request oscar-system#160), removed or simplified the relevant code - removed `gap/record.g` since the code is now obsolete; moved the contents of `tst/record.tst` to `JuliaInterface/tst/convert.tst` - changed the auxiliary dictionaries to use symbols as keys, in order to use the default conversions - adjusted some Julia code which worked only in pre-1.0 versions After these changes, the JuliaExperimental tests should work, thus the automatic test runs can be reactivated. (Currently I am rewriting the whole package JuliaExperimental, a pull request for that will be available on Monday.)
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 54.72% 72.1% +17.37%
==========================================
Files 37 43 +6
Lines 1683 2294 +611
==========================================
+ Hits 921 1654 +733
+ Misses 762 640 -122
|
fingolfin
approved these changes
Nov 23, 2018
| end ); | ||
|
|
||
| InstallMethod( \^, [ IsInt, IsExtPerm ], function( i, p ) | ||
| return ConvertedFromJulia( Julia.Base.("^")( ConvertedToJulia( i ), p![1] ) ); | ||
| return JuliaToGAP( IsInt, Julia.Base.("^")( GAPToJulia( i ), p![1] ) ); |
There was a problem hiding this comment.
By the way (not for this PR, but perhaps a future update of this code): you can write Base.\^, and the resulting code will be slight more efficient, as it will directly code the right rnam, instead of creating a temporary string and then turning it into an rnam via a hash table lookup in the GAP kernel. For bigger computations, all these temporary objects can add up to a significant extra load.
There was a problem hiding this comment.
@fingolfin Thanks for this hint.
This remark should become part of the documentation,
once there is a place for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed or simplified the relevant code
gap/record.gsince the code is now obsolete;moved the contents of
tst/record.tsttoJuliaInterface/tst/convert.tstin order to use the default conversions
After these changes, the JuliaExperimental tests should work,
thus the automatic test runs can be reactivated.
(Currently I am rewriting the whole package JuliaExperimental,
a pull request for that will be available on Monday.)