Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GAP.GAPObj -> GAP.Obj; GAP.GapFFE -> GAP.FFE #171

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

fingolfin
Copy link
Member

Also add a paranoia check to _JULIAINTERFACE_INTERNAL_INIT and
abort if GAP.FFE cannot be found (say, because you forgot to
recompile the kernel extension...)

Resolves #161

Also add a paranoia check to _JULIAINTERFACE_INTERNAL_INIT and
abort if GAP.FFE cannot be found (say, because you forgot to
recompile the kernel extension...)
@fingolfin fingolfin requested a review from sebasguts November 23, 2018 10:48
@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #171 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage    72.1%   72.08%   -0.02%     
==========================================
  Files          43       43              
  Lines        2294     2296       +2     
==========================================
+ Hits         1654     1655       +1     
- Misses        640      641       +1
Impacted Files Coverage Δ
LibGAP.jl/src/initialization.jl 92.3% <ø> (ø) ⬆️
LibGAP.jl/src/gap.jl 100% <ø> (ø) ⬆️
JuliaInterface/gap/calls.gi 100% <100%> (ø) ⬆️
LibGAP.jl/src/gap_to_julia.jl 95.76% <100%> (ø) ⬆️
JuliaInterface/src/JuliaInterface.c 95.32% <66.66%> (-0.54%) ⬇️

Copy link
Contributor

@sebasguts sebasguts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@sebasguts sebasguts merged commit 462859b into oscar-system:master Nov 23, 2018
@fingolfin fingolfin deleted the mh/gap-ffe-obj branch November 23, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants