JuliaFunction: set name and "location" of the function #182
Conversation
The latter means that using `Display` on a GAP function produced via `JuliaFunction` will at least give some indication about where the function comes from. It's not perfect, but certainly better than nothing (= what we currently get).
| "parse" | ||
| gap> Display(Julia.Base.parse); | ||
| function ( arg... ) | ||
| <<kernel code>> from Julia:parse |
There was a problem hiding this comment.
The <<kernel code>> from bit is fixed by GAP (at least currently), and so is the "FOO:BAR" format for the final part. Nice would of course be something like: <<Julia function Base.parse>>. Alas, I also don't really know how to produce Base.parse instead of parse. Perhaps it's as simply as checking for the parent module, getting its name, and prepending it (with a dot), and then repeating this until the top level is reached? Alas, we can figure that out later.
There was a problem hiding this comment.
I would say it is fine that way for now. If people start to complain we can still fix it. A sensible top-level would be Main I guess. Or maybe Top?
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=========================================
+ Coverage 72.34% 72.45% +0.1%
=========================================
Files 43 43
Lines 2311 2320 +9
=========================================
+ Hits 1672 1681 +9
Misses 639 639
|
The latter means that using
Displayon a GAP function produced viaJuliaFunctionwill at least give some indication about where the functioncomes from. It's not perfect, but certainly better than nothing (= what we
currently get).