Allow JuliaWrapper for Julia functions; allow calling them #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=========================================
+ Coverage 72.34% 72.55% +0.2%
=========================================
Files 43 43
Lines 2311 2317 +6
=========================================
+ Hits 1672 1681 +9
+ Misses 639 636 -3
|
sebasguts
approved these changes
Nov 29, 2018
| if (IS_JULIA_FUNC(obj)) { | ||
| return GET_JULIA_FUNC(obj); | ||
| } | ||
| // TODO: also allow wrapping auto-converted Julia objects??? |
There was a problem hiding this comment.
What do you mean by this comment?
There was a problem hiding this comment.
It is conceivable that this one might want to uniformly wrap all and any object returned by some Julia function. But then this might also be a boolean or Int64. In that case, perhaps we'd want to do recursion here... but this is rather hypothetical, so better not to worry here too much for now. Hence the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.