Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JULIA_LDFLAGS and JULIA_LIBS to Makefile.in #189

Conversation

sebasguts
Copy link
Contributor

This is a follow-up to gap-system/gap#3248

@sebasguts sebasguts requested a review from fingolfin January 29, 2019 13:56
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #189 into master will decrease coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #189     +/-   ##
=========================================
- Coverage   72.77%   72.38%   -0.4%     
=========================================
  Files          43       43             
  Lines        2336     2303     -33     
=========================================
- Hits         1700     1667     -33     
  Misses        636      636
Impacted Files Coverage Δ
LibGAP.jl/src/initialization.jl 90% <0%> (-2.6%) ⬇️
JuliaInterface/src/calls.c 99.13% <0%> (-0.06%) ⬇️
JuliaInterface/src/calls.h 100% <0%> (ø) ⬆️
JuliaInterface/src/convert.c 97.14% <0%> (+2.69%) ⬆️

fingolfin
fingolfin previously approved these changes Jan 31, 2019
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. Of course ideally, we should also check if those JULIA_* variables are actually defined, just in case somebody is pointing us at an older GAP version.

@sebasguts
Copy link
Contributor Author

Good idea.

@ThomasBreuer ThomasBreuer merged commit a3f2797 into oscar-system:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants