Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if JuliaInterface could be loaded #191

Merged

Conversation

sebasguts
Copy link
Contributor

when GAP is loaded into Julia

when GAP is loaded into Julia
@sebasguts sebasguts requested a review from fingolfin January 30, 2019 19:44
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #191 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   67.63%   67.63%   -0.01%     
==========================================
  Files          43       43              
  Lines        2299     2302       +3     
==========================================
+ Hits         1555     1557       +2     
- Misses        744      745       +1
Impacted Files Coverage Δ
LibGAP.jl/src/initialization.jl 86.66% <66.66%> (-2.23%) ⬇️

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that you have tested it (e.g. by manually removing / unsetting _JULIAINTERNAL_JULIAINTERFACE_LOADED to provoke a failure), this seems plausible enough.

@sebasguts
Copy link
Contributor Author

I did indeed. Also, I was reluctant to create a testcase, as the most sensible way is to move the package away.

@sebasguts sebasguts merged commit 8bc2d54 into oscar-system:master Jan 31, 2019
@sebasguts sebasguts deleted the check_juliainterface_loading branch January 31, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants