Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a Julia iterator in MinimalDegreeHard #202

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

ThomasBreuer
Copy link
Member

No description provided.

sebasguts
sebasguts previously approved these changes Feb 19, 2019
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #202 into master will increase coverage by 8.35%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   70.63%   78.99%   +8.35%     
==========================================
  Files          48       50       +2     
  Lines        3126     3308     +182     
==========================================
+ Hits         2208     2613     +405     
+ Misses        918      695     -223
Impacted Files Coverage Δ
JuliaExperimental/julia/loewy.jl 77.67% <100%> (+77.67%) ⬆️
JuliaExperimental/gap/loewy.gi 94.07% <0%> (ø)
JuliaExperimental/gap/loewy.gd 100% <0%> (ø)
JuliaExperimental/read.g 77.41% <0%> (+6.45%) ⬆️

@sebasguts
Copy link
Contributor

The missing coverage data comes from the fact that Primes is missing in Travis. Will try to add it to travis

@sebasguts
Copy link
Contributor

@ThomasBreuer The loewy test is too long, now travis terminates. I think you could tackle this by either shorten the loewy tests or add prints.

and the longer version is available in a separate test file
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every detail of this, but on the surface it looks fine to me.

@ThomasBreuer ThomasBreuer merged commit 1985953 into oscar-system:master Feb 21, 2019
@ThomasBreuer ThomasBreuer deleted the TB_Loewy_iterator branch February 21, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants