-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test normal and precompiled gap #211
Test normal and precompiled gap #211
Conversation
5049ded
to
a6748ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 91.31% 82.01% -9.31%
==========================================
Files 25 27 +2
Lines 1486 1896 +410
==========================================
+ Hits 1357 1555 +198
- Misses 129 341 +212
|
Please rebase so that CI runs again and we get proper coverage. |
a6748ed
to
4a8b51e
Compare
Done. |
47664c4
to
02228f1
Compare
02228f1
to
38d3128
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better now, though coverage is still weird -- it shows calls.c
but not convert.c
, JuliaInterface.c
and JuliaExperimental.c
. Perhaps just a bug in how Codecov displays the data, though?
Two minor suggestions, can also be ignored.
Co-Authored-By: sebasguts <[email protected]>
Argh, now I merged it, but we still have incorrect displayed data, right? |
Well, we'll just need to make another PR with coverage fixes :-). Besides missing some .c file, this is also missing all files from GAP.jl itself, i.e., from the /src/ dir. |
Oha, yeah, I also have some suspicion where that comes from. I will make another PR. |
No description provided.