Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test normal and precompiled gap #211

Merged

Conversation

sebasguts
Copy link
Contributor

No description provided.

@sebasguts sebasguts marked this pull request as ready for review March 8, 2019 13:41
@sebasguts sebasguts added the DO NOT MERGE DO NOT MERGE label Mar 8, 2019
@sebasguts sebasguts force-pushed the test_normal_and_precompiled_gap branch 3 times, most recently from 5049ded to a6748ed Compare March 8, 2019 13:53
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #211 into master will decrease coverage by 9.3%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   91.31%   82.01%   -9.31%     
==========================================
  Files          25       27       +2     
  Lines        1486     1896     +410     
==========================================
+ Hits         1357     1555     +198     
- Misses        129      341     +212
Impacted Files Coverage Δ
pkg/GAPJulia/JuliaInterface/src/calls.h 0% <0%> (ø)
pkg/GAPJulia/JuliaInterface/src/calls.c 59.63% <0%> (ø)

@sebasguts sebasguts requested a review from fingolfin March 8, 2019 14:09
@sebasguts sebasguts removed the DO NOT MERGE DO NOT MERGE label Mar 8, 2019
@fingolfin
Copy link
Member

Please rebase so that CI runs again and we get proper coverage.

@sebasguts sebasguts force-pushed the test_normal_and_precompiled_gap branch from a6748ed to 4a8b51e Compare March 10, 2019 13:48
@sebasguts
Copy link
Contributor Author

Done.

.travis.yml Outdated Show resolved Hide resolved
@sebasguts sebasguts force-pushed the test_normal_and_precompiled_gap branch from 47664c4 to 02228f1 Compare March 10, 2019 15:46
@sebasguts sebasguts force-pushed the test_normal_and_precompiled_gap branch from 02228f1 to 38d3128 Compare March 10, 2019 15:48
fingolfin
fingolfin previously approved these changes Mar 10, 2019
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now, though coverage is still weird -- it shows calls.c but not convert.c, JuliaInterface.c and JuliaExperimental.c. Perhaps just a bug in how Codecov displays the data, though?

Two minor suggestions, can also be ignored.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@sebasguts sebasguts dismissed stale reviews from fingolfin via aca78a2 March 11, 2019 06:39
@sebasguts sebasguts merged commit 70ac09b into oscar-system:master Mar 11, 2019
@sebasguts
Copy link
Contributor Author

Argh, now I merged it, but we still have incorrect displayed data, right?

@fingolfin
Copy link
Member

Well, we'll just need to make another PR with coverage fixes :-). Besides missing some .c file, this is also missing all files from GAP.jl itself, i.e., from the /src/ dir.

@sebasguts
Copy link
Contributor Author

Oha, yeah, I also have some suspicion where that comes from. I will make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants