-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to generate GAP functions from Julia #212
Make it possible to generate GAP functions from Julia #212
Conversation
This allows for:
|
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 25 25
Lines 1486 1486
=======================================
Hits 1357 1357
Misses 129 129 |
Please rebase so that CI runs again and we get proper coverage. |
f60a118
to
97fa9a7
Compare
Done. |
Clearly something is still broken wrt coverage, the C code has no coverzreported (and hence this PR shows no coverage). |
Am on a phone only now, but: do we still oasd --coverage in CFLAGS and LDFLAGS when compiling our code? (Possibly indirectly, if GAP was compiled with those flags) |
@fingolfin We don't for the GAP compiled by julia, I assume. Should I add this simply to the debug mode? Guess it won't hurt there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we don't get proper coverage return now, it is clear there there is a test case here, so all should be fine (and if not, we can revisit it later).
I'd perhaps insert one space after a comma, but other than that, let's just merge this.
Co-Authored-By: sebasguts <[email protected]>
No description provided.