Repair coverage (as Pkg gets installed to $HOME/.julia) #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Mar 10, 2019
etc/gather_coverage.jl
Outdated
| data = Codecov.process_folder("pkg/GAPJulia/JuliaInterface") | ||
| append!(data, Codecov.process_folder("pkg/GAPJulia/JuliaExperimental")) | ||
| append!(data, Codecov.process_folder()) | ||
| data = Codecov.process_folder("$(ENV["HOME"])") |
There was a problem hiding this comment.
That string quoting looks wrong
There was a problem hiding this comment.
Nope, that string quoting is correct in Julia.
sebasguts
changed the title
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 48.41% 91.31% +42.9%
==========================================
Files 43 25 -18
Lines 2803 1486 -1317
==========================================
Hits 1357 1357
+ Misses 1446 129 -1317 |
|
I will restart travis, as there was a hickup in downloading the GAP required packages. But one of the Jobs was successful, and the coverage looks much better now. |
sebasguts
force-pushed
the
repair_coverage
branch
from
cf5d038 to
d34e310
Compare
fingolfin
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.