Added conversion for two-dimensional arrays #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasguts
force-pushed
the
sg/two_dim_conversion
branch
from
06a741f to
0eafe08
Compare
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 75.21% 75.21%
=======================================
Files 5 5
Lines 456 456
=======================================
Hits 343 343
Misses 113 113 |
ThomasBreuer
requested changes
Apr 19, 2019
| new_array = Array{T,2}( undef, len_list_outer, len_list_inner ) | ||
| recursion_dict[obj] = new_array | ||
| for i in 1:len_list_outer | ||
| for j in 1:len_list_outer |
There was a problem hiding this comment.
thank you for spotting this, fixed now
| new_array = Array{Union{Nothing,T},2}( undef, len_list_outer, len_list_inner ) | ||
| recursion_dict[obj] = new_array | ||
| for i in 1:len_list_outer | ||
| for j in 1:len_list_outer |
What makes you say that? This would be a bug in general. Do you have some specific examples for this? |
sebasguts
force-pushed
the
sg/two_dim_conversion
branch
from
0eafe08 to
18e0348
Compare
|
I think this is a misunderstanding. Identical objects on the source side are turned into identical objects (on purpose). This is done by using |
|
Thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.