Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mark function for Julia object #229

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

sebasguts
Copy link
Contributor

This PR fixes the marking functions for Julia objects by using the marking functions introduced in gap-system/gap#3412

@sebasguts sebasguts marked this pull request as ready for review April 23, 2019 08:02
@sebasguts sebasguts force-pushed the sg/mark_julia_objs branch from ef16389 to 04f3714 Compare April 23, 2019 08:05
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #229 into master will increase coverage by 3.31%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   75.21%   78.52%   +3.31%     
==========================================
  Files           5        5              
  Lines         456      517      +61     
==========================================
+ Hits          343      406      +63     
+ Misses        113      111       -2
Impacted Files Coverage Δ
pkg/GAPJulia/JuliaInterface/src/JuliaInterface.c 93.26% <100%> (+2.41%) ⬆️
pkg/GAPJulia/JuliaInterface/src/calls.c 92.97% <100%> (+1.25%) ⬆️

@sebasguts sebasguts force-pushed the sg/mark_julia_objs branch from 04f3714 to 0318e06 Compare April 23, 2019 08:12
fingolfin
fingolfin previously approved these changes Apr 23, 2019
to ensure julia function object is marked correctly if
julia function gets marked.
@sebasguts sebasguts force-pushed the sg/mark_julia_objs branch from 0318e06 to 801e22c Compare April 25, 2019 15:43
@sebasguts sebasguts merged commit b614a52 into oscar-system:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants