Some compat functions #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 75.38% 75.38%
=======================================
Files 5 5
Lines 459 459
=======================================
Hits 346 346
Misses 113 113 |
sebasguts
force-pushed
the
sg/gap_compat
branch
4 times, most recently
from
a5bc81e to
55f9556
Compare
Merged
fingolfin
requested changes
May 7, 2019
fingolfin
reviewed
May 9, 2019
| end | ||
|
|
||
| function LoadPackageAndExposeGlobals(package::String, mod::Module; all_globals::Bool = false) | ||
| current_gvar_list = EvalString("ShallowCopy(NamesGVars())") |
There was a problem hiding this comment.
Minor remark: We only need this if all_globals is false. So we may want to execute it conditionally, no? Also, couldn't you write Globals.ShallowCopy(Globals.NamesGVars()) instead of using EvalString?
|
I also fixed your minor remark. Could you approve again? |
fingolfin
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gapmacro which performsEvalStringLoadPackageAndExposeGlobalsto expose the package globals from a load into a modules scope (default: Main)