Some small examples to start with in README.md #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 75.38% 75.38%
=======================================
Files 5 5
Lines 459 459
=======================================
Hits 346 346
Misses 113 113 |
fingolfin
requested changes
May 21, 2019
|
(Of course I am not asking you to write that manual here -- the change request is purely for some phrasing in you PR). |
sebasguts
force-pushed
the
sg/first_release
branch
from
4e3abe1 to
beb0fd0
Compare
|
I see. I applied your suggests :) |
fingolfin
reviewed
May 21, 2019
README.md
Outdated
| julia> x = GAP.julia_to_gap([1,2,3]) | ||
| GAP: [ 1, 2, 3 ] | ||
| ``` | ||
| Converting back to Julia is done using `GAP.gap_to_julia`. However, for this one needs to specify the desired type of the resulting object. For example, to convert the GAP list of integers we just defined back to Julia, we might do this: |
There was a problem hiding this comment.
Why is this one long line, while lines 29/30 is wrapped?
There was a problem hiding this comment.
I think because you made this line longer because of your suggestions ;). Anyway, fixed it.
fingolfin
reviewed
May 21, 2019
README.md
Outdated
| ``` | ||
| one may call any GAP function by prefixing its name with `GAP.Globals.`. For example: | ||
| ```julia | ||
| julia> GAP.Globals.SymmetricGroup( 3 ) |
There was a problem hiding this comment.
I am not going to request a change for this, but I note that once more, this is formatted differently in terms of whitespace than the other example inputs :-).
fingolfin
approved these changes
May 21, 2019
sebasguts
force-pushed
the
sg/first_release
branch
from
beb0fd0 to
d2e2b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.