JuliaInterface: move macros to macros.jl #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 69.95% 69.95%
=======================================
Files 49 50 +1
Lines 3258 3258
=======================================
Hits 2279 2279
Misses 979 979
|
sebasguts
approved these changes
Jun 17, 2019
| directly inside GAP. The second example returns the function `SymmetricGroup` | ||
| via `@gap(SymmetricGroup)`, then calls that function with the argument `3`. | ||
| """ | ||
| macro gap(str) |
There was a problem hiding this comment.
Honestly, I am not even sure we should keep this macro.
Its functionality is very limited, and it is not exactly clear to the user what works and what does not work. So it might be easier to just remove it.
Although, if you have some experience, it leads to nicer and shorter code, specially in presentations. So I am not completely sure what to do with it . . .
sebasguts
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards breaking up
gap.jl. It'll conflict with PR #249, but I am prepared to resolve that.