Use ccache on Travis #261
Merged
Use ccache on Travis #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 69.95% 69.95%
=======================================
Files 49 49
Lines 3258 3258
=======================================
Hits 2279 2279
Misses 979 979 |
sebasguts
approved these changes
Jun 17, 2019
| env: | ||
| global: | ||
| - MAKEFLAGS="-j4" | ||
| - JULIA_TRACK_COVERAGE=yes | ||
| - PATH="/usr/lib/ccache:$PATH" |
There was a problem hiding this comment.
This is not necessary, travis adds /usr/lib/ccache automatically to the path when ccache is enabled.
Suggested change
| - PATH="/usr/lib/ccache:$PATH" | |
| - PATH="/usr/lib/ccache:$PATH" |
There was a problem hiding this comment.
As I understood it, it only does so with language: c or language: c++. In any case, I don't see /usr/lib/ccache twice in the PATH... But sure, I can try what happens if I remove that line.
There was a problem hiding this comment.
Ah yeah, that might be a restriction. No, it is fine for me as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure whether this is actually useful, though, as we spend very little time compiling stuff (mostly GAP), and far more with downloading GAP, and running the tests.
It's a bit difficult to measure the benefit of this without merging it, though, as of course it only helps once the cache has been filled. As it is, I am not even fully sure this works as intended...