Place call_gap_func in the main module to ensure it is accessible
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamed-barakat
approved these changes
Jun 21, 2019
fingolfin
reviewed
Jun 21, 2019
sebasguts
force-pushed
the
sg/callfunc_eval
branch
from
f914383 to
549af58
Compare
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
=======================================
Coverage 70.06% 70.06%
=======================================
Files 50 50
Lines 3260 3260
=======================================
Hits 2284 2284
Misses 976 976
|
|
Done. |
fingolfin
approved these changes
Jun 26, 2019
fingolfin
reviewed
Jun 26, 2019
src/GAP.jl
Outdated
| Base.MainInclude.eval(:( | ||
| (func::$MPtr)(args...; kwargs...) = GAP.call_gap_func(func, args...; kwargs...) | ||
| (func::$MPtr)(args...; kwargs...) = $(call_gap_func)(func, args...; kwargs...) |
There was a problem hiding this comment.
So it doesn't work like this, without the global above?
Suggested change
| (func::$MPtr)(args...; kwargs...) = $(call_gap_func)(func, args...; kwargs...) | |
| (func::$MPtr)(args...; kwargs...) = $(GAP.call_gap_func)(func, args...; kwargs...) |
I just tested that locally, and it seemed to work fine? If there is no reason, let's use mine. If there is a reason, let's add a comment explaining it?
There was a problem hiding this comment.
@sebasguts am I missing something?
There was a problem hiding this comment.
@fingolfin I am not completely sure if this also works when GAP is loaded as a dependency of another module. Will test, and then change it accordingly (either comment or your version).
There was a problem hiding this comment.
Tested, and your approach is valid. I updated the PR.
even when the GAP module is not loaded into main (e.g., if loaded from another module)
sebasguts
force-pushed
the
sg/callfunc_eval
branch
from
549af58 to
15b0972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even when the GAP module is not loaded into main (e.g., if loaded
from another module)