Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use --depth=1 when cloning/pull GAP repository #274

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

fingolfin
Copy link
Member

Pulling in a shallow repository can cause all kinds of problems.

This should resolve the root cause for PR #273. That said, @mohamed-barakat probably still will have to rm -rf ~/.julia/dev/GAP/gap beforehand.

Pulling in a shallow repository can cause all kinds of problems.
@codecov
Copy link

codecov bot commented Jun 30, 2019

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   70.64%   70.64%           
=======================================
  Files          51       51           
  Lines        3260     3260           
=======================================
  Hits         2303     2303           
  Misses        957      957
Impacted Files Coverage Δ
deps/build.jl 0% <ø> (ø) ⬆️

@fingolfin fingolfin merged commit 83c36a9 into oscar-system:master Jul 3, 2019
@fingolfin fingolfin deleted the mh/no-shallow-clones branch July 3, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants