Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build system of our two GAP packages #295

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

fingolfin
Copy link
Member

Those parts of the Makefile which are shared between multiple GAP packages are
now in a separate file Makefile.gappkg to make it easier to apply fixes and
improvements to all packages using it (see gap-system/gap#3683)

Those parts of the Makefile which are shared between multiple GAP packages are
now in a separate file Makefile.gappkg to make it easier to apply fixes and
improvements to all packages using it.
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #295 into master will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #295      +/-   ##
=========================================
+ Coverage   69.55%   69.9%   +0.35%     
=========================================
  Files          57      57              
  Lines        3757    3738      -19     
=========================================
  Hits         2613    2613              
+ Misses       1144    1125      -19
Impacted Files Coverage Δ
src/GAP.jl 91.89% <0%> (+2.41%) ⬆️
src/julia_to_gap.jl 95.38% <0%> (+2.84%) ⬆️
src/ccalls.jl 98.38% <0%> (+3.07%) ⬆️
src/packages.jl 94.73% <0%> (+4.73%) ⬆️
pkg/GAPJulia/JuliaExperimental/julia/gapperm.jl 88.14% <0%> (+5.53%) ⬆️

@fingolfin fingolfin changed the title Refactor build system of our two GAP packages (WIP) Refactor build system of our two GAP packages Nov 14, 2019
@fingolfin fingolfin merged commit 8624406 into oscar-system:master Nov 14, 2019
@fingolfin fingolfin deleted the mh/buildsys branch November 14, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant