Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try harder to update Makefile.gappkg, but don't die over it #307

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

fingolfin
Copy link
Member

Fixes #304

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #307 into master will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   71.24%   71.71%   +0.46%     
==========================================
  Files          59       59              
  Lines        3979     3981       +2     
==========================================
+ Hits         2835     2855      +20     
+ Misses       1144     1126      -18
Impacted Files Coverage Δ
test/macros.jl 100% <0%> (ø) ⬆️
src/julia_to_gap.jl 94.02% <0%> (+1.49%) ⬆️
src/GAP.jl 92.1% <0%> (+2.63%) ⬆️
src/ccalls.jl 98.43% <0%> (+3.12%) ⬆️
src/packages.jl 94.73% <0%> (+4.73%) ⬆️
pkg/GAPJulia/JuliaExperimental/julia/gapperm.jl 88.88% <0%> (+6.28%) ⬆️

@kalmarek
Copy link

the code from this branch works for me

@fingolfin fingolfin merged commit f35d433 into oscar-system:master Jan 17, 2020
@fingolfin fingolfin deleted the mh/fix-julia-1.3-build branch January 17, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding GAP (with or without packages) fails
2 participants