process the main manuals in the installation of GAP #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=========================================
- Coverage 71.59% 69.99% -1.6%
=========================================
Files 59 57 -2
Lines 3960 3756 -204
=========================================
- Hits 2835 2629 -206
- Misses 1125 1127 +2
|
fingolfin
requested changes
Jan 21, 2020
| @@ -38,6 +38,9 @@ if install_gap | |||
| run(`./autogen.sh`) | |||
| run(`./configure --with-gc=julia --with-julia=$(julia_binary)`) | |||
| run(`make -j$(Sys.CPU_THREADS)`) | |||
| cd("doc") | |||
| run(`make_doc nopdf`) | |||
There was a problem hiding this comment.
This won't work, you'd need this:
Suggested change
| run(`make_doc nopdf`) | |
| run(`./make_doc nopdf`) |
But even better is to invoke make html (I've submitted PR #321 doing that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.